Skip to content

GH-48094: [C++] Restrict SecureString capacity tail check to Linux#49906

Merged
pitrou merged 1 commit into
apache:mainfrom
ArnavBalyan:arnavb/secure-string-msvc-asan
May 5, 2026
Merged

GH-48094: [C++] Restrict SecureString capacity tail check to Linux#49906
pitrou merged 1 commit into
apache:mainfrom
ArnavBalyan:arnavb/secure-string-msvc-asan

Conversation

@ArnavBalyan
Copy link
Copy Markdown
Member

@ArnavBalyan ArnavBalyan commented May 1, 2026 •
edited
Loading

Rationale for this change

What changes are included in this PR?

  • Guard for platform specific behavior.

Are these changes tested?

  • Yes

Are there any user-facing changes?

  • Yes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

⚠️ GitHub issue #48094 has been automatically assigned in GitHub to PR creator.

@ArnavBalyan
Copy link
Copy Markdown
Member Author

ArnavBalyan commented May 1, 2026

cc @pitrou thanks

@pitrou
Copy link
Copy Markdown
Member

pitrou commented May 5, 2026

Can we condition this on MSVC rather than Linux? The test can still be used under macOS and other platforms.

@ArnavBalyan ArnavBalyan force-pushed the arnavb/secure-string-msvc-asan branch from 69d0341 to 1416cc9 Compare May 5, 2026 09:53
@ArnavBalyan ArnavBalyan force-pushed the arnavb/secure-string-msvc-asan branch from 1416cc9 to 1279689 Compare May 5, 2026 09:56
@ArnavBalyan
Copy link
Copy Markdown
Member Author

ArnavBalyan commented May 5, 2026

done thanks

pitrou
pitrou approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @ArnavBalyan

@pitrou pitrou merged commit 25e4fdb into apache:main May 5, 2026
54 of 56 checks passed
@pitrou pitrou removed the awaiting review Awaiting review label May 5, 2026
@pitrou pitrou mentioned this pull request May 5, 2026
Closed
@pitrou
Copy link
Copy Markdown
Member

pitrou commented May 5, 2026

Oops, I should have changed the PR title before merging. Too late.

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label May 5, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow Bot commented May 5, 2026

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 25e4fdb.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow Bot commented May 14, 2026

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 25e4fdb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Arrow test 'arrow-utility-test' contains heap-buffer-overflow error

2 participants

@ArnavBalyan @pitrou